Add comments for golibmc's connection pool implementation#95
Merged
tclh123 merged 2 commits intodouban:masterfrom Feb 25, 2019
Merged
Add comments for golibmc's connection pool implementation#95tclh123 merged 2 commits intodouban:masterfrom
tclh123 merged 2 commits intodouban:masterfrom
Conversation
Contributor
Author
|
As this PR should not break any thing, I'm going to merge this for my next bugfix PR. Feel free to comment if you find any problems with this PR. |
tclh123
added a commit
that referenced
this pull request
Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mainly add comments for golibmc's connection pool implementation.
Take it as a supplementary of #57.
It takes a lot of comments from the original code https://github.com/golang/go/blob/master/src/database/sql/sql.go , and adds some
FIXME.