nodejs compatibility #2
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've been enjoying using jsparse, but I wanted to be able to test my parsers in nodejs, and figured it'd also be nice to have the option to put everything within its own namespace, so I hacked up this patch.
I haven't yet updated the examples, but tests.js passes (in 3ms! and ~100ms including startup time and everything), and I added a browser invocation of the tests.js code.
There are two backwards incompatible changes introduced. One is that to use it the old way (with everything in the toplevel namespace) in a browser you must call
jsparse.inject_into(window)
And even with that, memoize must be set on jsparse, it can't be set in the toplevel namespace.
Anyways, thanks for writing jsparse!