fix: status page was non-navigable, because of a bug with query param…#258
Merged
Conversation
|
🚅 Environment control-layer-pr-258 in industrious-light has no services deployed. |
railway-app
Bot
temporarily deployed
to
control-layer (industrious-light / control-layer-pr-258)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a navigation bug where query parameters were being lost when updating the search query or page number in the Models component. The issue occurred because the component was creating a new URLSearchParams object without preserving existing parameters like the view parameter (which controls whether the page displays in "grid" or "status" mode).
Key Changes
- Changed
setSearchParamsto use a functional update pattern that preserves existing URL parameters - Added logic to conditionally delete
searchandpageparameters when they're empty or at default values (page 1)
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
fergusfinn
added a commit
that referenced
this pull request
Nov 28, 2025
fergusfinn
added a commit
that referenced
this pull request
Nov 28, 2025
… across chunks (#262) * handle incomplete bytes spread across chunks * feat(deps): bump fusillade to 0.4.0 * chore(deps): update dependency vite to v7.2.4 (#263) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update react monorepo (#264) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency lucide-react to ^0.555.0 (#270) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update rust docker tag to v1.91.1 (#269) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update rust crate criterion to 0.7 (#268) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency typescript-eslint to v8.48.0 (#267) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update tanstack-query monorepo to v5.90.11 (#265) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @playwright/test to v1.57.0 (#266) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Remove fusillade package from release-please config (#261) Removed fusillade package configuration from release-please. * fix: status page was non-navigable, because of a bug with query parameters (#258) * feat: optimized batch creation UI (#254) * fix: enter submit create batch modal * fix: page params in batches * feat: new batch upload flow * fix: tests * fix: tests * fix(deps): update rust crate prometheus to 0.14 (#273) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/checkout action to v6 (#276) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/setup-node action to v6 (#277) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(main): release 0.11.0 (#257) * fix: update cargo.lock * chore: formatting --------- Co-authored-by: Fergus <fergus.barratt00@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Seb Ringrose <seb@doubleword.ai> Co-authored-by: pjb157 <84070455+pjb157@users.noreply.github.com>
hachall
pushed a commit
that referenced
this pull request
Jan 23, 2026
hachall
pushed a commit
that referenced
this pull request
Jan 23, 2026
… across chunks (#262) * handle incomplete bytes spread across chunks * feat(deps): bump fusillade to 0.4.0 * chore(deps): update dependency vite to v7.2.4 (#263) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update react monorepo (#264) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency lucide-react to ^0.555.0 (#270) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update rust docker tag to v1.91.1 (#269) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update rust crate criterion to 0.7 (#268) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency typescript-eslint to v8.48.0 (#267) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update tanstack-query monorepo to v5.90.11 (#265) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @playwright/test to v1.57.0 (#266) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Remove fusillade package from release-please config (#261) Removed fusillade package configuration from release-please. * fix: status page was non-navigable, because of a bug with query parameters (#258) * feat: optimized batch creation UI (#254) * fix: enter submit create batch modal * fix: page params in batches * feat: new batch upload flow * fix: tests * fix: tests * fix(deps): update rust crate prometheus to 0.14 (#273) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/checkout action to v6 (#276) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/setup-node action to v6 (#277) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(main): release 0.11.0 (#257) * fix: update cargo.lock * chore: formatting --------- Co-authored-by: Fergus <fergus.barratt00@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Seb Ringrose <seb@doubleword.ai> Co-authored-by: pjb157 <84070455+pjb157@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eters