fix(deps): update dependency lucide-react to v1 #911
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,7 +49,7 @@ | |
| "clsx": "^2.1.1", | ||
| "cmdk": "^1.1.1", | ||
| "date-fns": "^4.1.0", | ||
| "lucide-react": "^1.0.0", | ||
|
There was a problem hiding this comment. Non-blocking: The lucide-react update to v1 is safe. According to the official migration guide, the only breaking change in v1 is the removal of brand icons (GitHub, Facebook, Twitter, etc.), and none of those icons are used in this codebase. The icon API and props remain unchanged. Why it matters: Major version bumps can introduce breaking changes. In this case, the migration is straightforward because:
Suggested fix: No change needed to this line. However, ensure the full test suite passes after the update. There was a problem hiding this comment. Non-blocking: The lucide-react upgrade from 0.577.0 to ^1.0.0 (resolves to 1.14.0) is safe for this codebase. Why it matters: Lucide v1 removed several brand icons (Github, Gitlab, Facebook, etc.) as documented in the migration guide. I verified via grep that none of these removed icons are imported anywhere in the codebase. Additionally, v1 now sets Suggested fix: No action required, but consider pinning to a specific version (e.g., There was a problem hiding this comment. Non-blocking: The lucide-icons maintainers noted that v1.0.0 was "published unintentionally" and recommended using v1.0.1+ instead (see release notes). Why it matters: Using an unintentionally published version may indicate potential instability or issues that were fixed in subsequent patch releases. Suggested fix: Consider updating to |
||
| "next-themes": "^0.4.6", | ||
| "openai": "^6.0.0", | ||
| "react": "^19.1.1", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Consider being more explicit about the minimum version.
Why it matters: Using
^1.0.0allows pnpm to auto-update to any 1.x version. While the lockfile pins 1.14.0 for reproducible builds, being explicit about the minimum tested version helps future maintainers understand what version was actually tested.Since 1.0.0 was an accidental release, specifying
^1.0.0might give the impression that 1.0.0 was intentionally targeted.Suggested fix: Consider updating to
"^1.14.0"or at minimum"^1.0.1"(to skip the accidental 1.0.0 release) to be explicit about the minimum version with known compatibility.