fix(vllm): make vllm-omni respect the selected torch backend#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a Docker build failure in the vLLM source-install path by making the vllm-omni install respect the selected Torch backend.
Problem
When install_vllm.sh is used to install vLLM from source in a CUDA environment, it installs vllm-omni before building vLLM.
The issue was that the vllm-omni install did not use the selected Torch backend. That could pull in a Torch build for a different CUDA version than the one expected by the image being built, which caused the Docker build to fail with a CUDA/Torch version mismatch.
Solution
Update container/deps/vllm/install_vllm.sh so that CUDA installs of vllm-omni use the same --torch-backend selected for the rest of the vLLM install flow. This applies to both the PyPI install path and the source fallback path