Conversation
lwjohnst86
left a comment
lwjohnst86
left a comment
There was a problem hiding this comment.
Great first try! 🎉 I've made a few suggested changes and comments that will require quite a bit of rework to do, so I'll not review more until those changes are suggested.
_quarto/.gitignore
Outdated
There was a problem hiding this comment.
These git ignore lines should be in the root .gitignore, not here.
There was a problem hiding this comment.
Rather than use HTML, you can write Markdown in EJS files. It will be much easier for others to read compared to HTML.
There was a problem hiding this comment.
It's really not necessary to use JavaScript in here.
There was a problem hiding this comment.
file names should not have numbers before them. Can you please rename everything so it is simply e.g. homepage, without the number?
| clinicians, health scientists and data scientists across all seven Steno | ||
| Diabetes Centres. | ||
|
|
||
| ```{=html} |
There was a problem hiding this comment.
Use Markdown instead of HTML.
There was a problem hiding this comment.
Since this is auto-created by the Quarto listings, you don't need to keep it. You can delete
data/people.json
Outdated
There was a problem hiding this comment.
You can delete this file, since the YAML is the one Quarto uses.
| orcid: 0000-0003-4169-2616 | ||
| image: https://avatars.githubusercontent.com/u/6662983?v=4 | ||
| wps: [WP1] | ||
| isLead: true |
There was a problem hiding this comment.
Rather than have a generic description section in the EJS, you can put a description field here where people can add what they want to have a personal touch.
da/1homepage/index.qmd
Outdated
| @@ -0,0 +1,41 @@ | |||
| --- | |||
| title: "DP-Next: Sustainable Type 2 Diabetes Prevention" | |||
| css: /settings/style.css | |||
There was a problem hiding this comment.
Each file doesn't need this css setting. If you put the css in the _quarto.yml file, it applies it to all files.
|
Maybe to start, you can create many new PRs with one a few changes made per PR? This PR is much too big to effectively review. For example, any given PR should ideally have only a few files changes, or if there are many files changed, they all change the same thing (e.g. fixing a typo across many files). |
|
That was also my original thought, to create this as a playground to see what could work well and what does not work well and then making a new branch from the main where I created the parts that we wanted to keep and submitting a new PR after implementing each new part (to keep it simple for review, as I never expected this to be approved at the first go) Thanks for going through everything. After our meeting tomorrow I will go through your comments. The numbering before the different pages was to keep the order, but this can of course be removed. |
Removed CSS reference from the who-we-are.qmd file.
Remove CSS reference from homepage index.
Removed CSS reference from research overview.
Removed CSS reference from who-we-are.qmd
3 participants
Reorganized content into language-specific structure under da/ and en/ sections
Each section have following structure
1homepage2participant3researcher4wp5whoweare6publications7supportConfiguration
_quarto.yml: shared/base config_quarto-da.yml: Danish profile (render list + Danish navbar)_quarto-en.yml: English profile (render list + English navbar)Who-we-are listing data is sourced from:
data/people.ymlCustom listing template:
_templates/wp-grid.ejsThe listing is configured in:
da/5whoweare/who-we-are.qmden/5whoweare/who-we-are.qmdSettings such as style is located in a separate settings folder
All images is located in a separated images folder
OBS! Text is AI generated to show how different sections would look like as well as data from "-
data/people.yml" if one person is part of multiple WP - so errors in affiliation, wp and so on