Merged
Conversation
tim-yao
commented
Mar 20, 2024
| if [ -e tests/newman/tide.collection.json ] | ||
| then | ||
| if [[ ${TEST_NEWMAN_DISABLE_CORE} == true ]] | ||
| if [[ "${TEST_NEWMAN_DISABLE_CORE}" == "true" ]] |
Contributor
Author
There was a problem hiding this comment.
This fixed the sh: true: unknown operand error in GHA API job step
tim-yao
commented
Mar 20, 2024
Comment on lines
+66
to
+69
| - name: prepare-report-api | ||
| if: ${{ inputs.test_type == ':postman:' }} | ||
| run: | | ||
| echo "REPORT_TEXT=API test report is stored in the CI job summary artifacts" >> $GITHUB_ENV |
Contributor
Author
There was a problem hiding this comment.
API test doesn't have a report stored in the cloud so no report URL can be sent to Slack, added a specific message for it.
klaukl
approved these changes
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make API test Slack notification back to work. See below the comments I made.