Skip to content

Further fixes for incorrect reporting#45

Merged
FleetAdmiralButter merged 1 commit intomainfrom
feature/DDS-1852-incorrect-reporting
Apr 24, 2024
Merged

Further fixes for incorrect reporting#45
FleetAdmiralButter merged 1 commit intomainfrom
feature/DDS-1852-incorrect-reporting

Conversation

@FleetAdmiralButter
Copy link
Contributor

@FleetAdmiralButter FleetAdmiralButter commented Apr 24, 2024

  1. Make workflow_id and workflow_reusable_name required (these parameters are already implemented by the caller workflows).
  2. The GitHub API occasionally reports the status of previously run jobs as 'in_progress', even though there is a needs statement to indicate a dependency. I've added a 15 second sleep before actually starting the job to hopefully work around this.

@FleetAdmiralButter FleetAdmiralButter changed the title Try to work around API response Further fixes for incorrect reporting Apr 24, 2024
@FleetAdmiralButter FleetAdmiralButter self-assigned this Apr 24, 2024
@FleetAdmiralButter FleetAdmiralButter merged commit 2483fa8 into main Apr 24, 2024
@FleetAdmiralButter FleetAdmiralButter deleted the feature/DDS-1852-incorrect-reporting branch April 24, 2024 05:24
@tim-yao tim-yao mentioned this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants