Merged
Conversation
klaukl
previously approved these changes
Jun 6, 2024
tim-yao
commented
Jun 6, 2024
Comment on lines
-115
to
-117
| - name: Get repo name | ||
| id: repo_name | ||
| run: echo "::set-output name=REPO_NAME::$(echo ${GITHUB_REPOSITORY#*/})" |
Contributor
Author
There was a problem hiding this comment.
This is redundant, not used at all. There is a warning for using set-output, so I decide to remove it.
tim-yao
commented
Jun 6, 2024
Comment on lines
-154
to
-160
| - | ||
| name: Upload test results | ||
| uses: actions/upload-artifact@v3 | ||
| if: always() | ||
| with: | ||
| name: test-results | ||
| path: /app/reports/ |
Contributor
Author
There was a problem hiding this comment.
This is duplicated test report uploading, removed.
tim-yao
commented
Jun 6, 2024
Comment on lines
-173
to
-179
| - | ||
| name: Store Cucumber Cloud test report URL | ||
| uses: actions/upload-artifact@v3 | ||
| if: always() | ||
| with: | ||
| name: ${{ inputs.name }}-report-url | ||
| path: /app/reports/report-url.txt |
Contributor
Author
There was a problem hiding this comment.
duplication, removed.
klaukl
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://digital-vic.atlassian.net/browse/SDPTA-1067
There are too many warnings in the GHA, need to clean up to let the code future proof.
Tested and it looks all ok now. See https://github.com/dpc-sdp/sdp-testing/actions/runs/9394736636