Conversation
klaukl
commented
Oct 31, 2024
klaukl
commented
Oct 31, 2024
tim-yao
reviewed
Nov 1, 2024
Contributor
|
Hey, @GROwen Keith have done a code split to make the workflow more reusable, could you please review it to see if it addresses your suggestion? Cheers! |
tim-yao
reviewed
Nov 5, 2024
tim-yao
reviewed
Nov 5, 2024
tim-yao
reviewed
Nov 6, 2024
tim-yao
previously approved these changes
Nov 6, 2024
GROwen
requested changes
Nov 6, 2024
Contributor
Author
|
@GROwen changed requested done. Could you please check? Thanks |
GROwen
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs when on uat or master branch and - use commit sha from the triggered commit to get jira ID i.e. SCFA-123. May have edge case issues but any updates we want reflected via release probably should have a Jira ID otherwise it will be out of sync
https://digital-vic.atlassian.net/browse/SD-324
Implementation test on reference: https://github.com/dpc-sdp/reference-sdp-vic-gov-au/actions/runs/11472522262