Skip to content

[SD-324] Jira test notification#56

Merged
klaukl merged 62 commits intomainfrom
SD-324-e2e-jira-v2
Nov 8, 2024
Merged

[SD-324] Jira test notification#56
klaukl merged 62 commits intomainfrom
SD-324-e2e-jira-v2

Conversation

@klaukl
Copy link
Contributor

@klaukl klaukl commented Oct 31, 2024

Runs when on uat or master branch and - use commit sha from the triggered commit to get jira ID i.e. SCFA-123. May have edge case issues but any updates we want reflected via release probably should have a Jira ID otherwise it will be out of sync

https://digital-vic.atlassian.net/browse/SD-324

Implementation test on reference: https://github.com/dpc-sdp/reference-sdp-vic-gov-au/actions/runs/11472522262

  notify_jira:
    needs: [fe_smoke, fe_core_visual, fe_custom_visual, fe_custom, fe_core]
    if: (github.ref_name == 'uat' || github.ref_name == 'master')
    uses: dpc-sdp/github-actions/.github/workflows/notify_jira.yml@main
    secrets: inherit
    with:
      status: ${{ 
        (needs.fe_smoke.result == 'failure' || 
        needs.fe_core_visual.result == 'failure' || 
        needs.fe_custom_visual.result == 'failure' || 
        needs.fe_custom.result == 'failure' || 
        needs.fe_core.result == 'failure') 
        && 'failed' || 'passed' }}

@klaukl klaukl marked this pull request as ready for review October 31, 2024 22:51
@klaukl klaukl requested review from GROwen and tim-yao October 31, 2024 22:51
@tim-yao
Copy link
Contributor

tim-yao commented Nov 5, 2024

Hey, @GROwen Keith have done a code split to make the workflow more reusable, could you please review it to see if it addresses your suggestion? Cheers!

@klaukl klaukl requested a review from tim-yao November 6, 2024 01:32
tim-yao
tim-yao previously approved these changes Nov 6, 2024
@klaukl klaukl requested a review from GROwen November 6, 2024 22:20
@klaukl
Copy link
Contributor Author

klaukl commented Nov 6, 2024

@GROwen changed requested done. Could you please check? Thanks

@klaukl klaukl merged commit 7db358e into main Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants