Skip to content

[SD-324] Mutliple ID fix#58

Merged
klaukl merged 3 commits intomainfrom
SD-324-fix-multiple-ids
Nov 10, 2024
Merged

[SD-324] Mutliple ID fix#58
klaukl merged 3 commits intomainfrom
SD-324-fix-multiple-ids

Conversation

@klaukl
Copy link
Contributor

@klaukl klaukl commented Nov 9, 2024

  • Fixed issue where mutliple ID extracted like [SCFA-123] [SCFA-333] and caused unhandled error. Changed to only take the 1st one. Usually should only have 1 ID. Error was found when I mixed tickets manually

@klaukl klaukl requested review from GROwen and tim-yao November 9, 2024 09:30
@klaukl klaukl marked this pull request as ready for review November 10, 2024 22:35
@klaukl klaukl merged commit 742eef3 into main Nov 10, 2024
# Extract JIRA ID
JIRA_ID=$(echo "$commit_message" | grep -oE 'SCFA-[0-9]{1,5}' || true) # Prevents non-zero exit code
JIRA_ID=$(echo "$commit_message" | grep -oE 'SCFA-[0-9]{1,5}' | head -n 1 || true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @klaukl , I'm looking into an alternative using awk to make this more generic.

@GROwen GROwen deleted the SD-324-fix-multiple-ids branch November 11, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants