Conversation
anthony-malkoun
approved these changes
Jan 29, 2025
Contributor
anthony-malkoun
left a comment
There was a problem hiding this comment.
We've gone through this extensively already Keith so happy to approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added GHA to support tide release. Mainly changed to be more of an adhoc call on release branch to do config export step. The original one required an automation/branch and then ran config export on it, pushes to a release/branch with naming like release/1.52.0 which has been changed due to JIRA.
Create PR GHA is a placeholder and not used yet. Its optional and used to reduce lagoon build / resources because currently: awx sdp-upgrade creates release/branch -> commits platform files / tasks -> opens PR -> config export commit back to release branch (which triggers another lagoon build so 2 going at the same time)
--> open PR should be skipped for tide and the config export step can open PR after
Since we are trying to standardise things and start from JIRA which currently creates a release/SCFA-xxxx after (https://github.com/dpc-sdp/sdp-ansible-upgrade/commit/fa3a91b59b2b7eb1ee3ed51fb1d82e57e6115110) streamline things between ripple/tide release. The AWX template which triggers is sdp-upgrade:
Note: Haven't replaced the existing config export. Only replace the exist push UAT