Fix initialization order in KafkaClient#2119
Merged
jeffwidman merged 3 commits intodpkp:masterfrom Sep 17, 2020
Merged
Conversation
jeffwidman
approved these changes
Sep 17, 2020
Contributor
jeffwidman
left a comment
jeffwidman
left a comment
There was a problem hiding this comment.
LGTM, although could you add a comment? It'd be all too easy for this problem to creep back in later from someone who doesn't realize the order matters for these specific attributes...
jeffwidman
reviewed
Sep 17, 2020
jeffwidman
reviewed
Sep 17, 2020
jeffwidman
reviewed
Sep 17, 2020
jeffwidman
reviewed
Sep 17, 2020
jeffwidman
approved these changes
Sep 17, 2020
gabriel-tincu
pushed a commit
to aiven/kafka-python
that referenced
this pull request
Sep 22, 2020
Fix initialization order in KafkaClient
chandlernine
pushed a commit
to layer9ai/kafka-python
that referenced
this pull request
Jun 9, 2021
Fix initialization order in KafkaClient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this resolve #2118
This change is