fix (server): fix replication partial sync flow #5189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adi_holden <adi@dragonflydb.io>
abhijat
reviewed
May 28, 2025
kostasrim
reviewed
May 28, 2025
| std::make_error_code(errc::state_not_recoverable), | ||
| absl::StrCat("Partial sync was unsuccessful because entry #", lsn, | ||
| " was dropped from the buffer. Current lsn=", journal->GetLsn())); | ||
| FinalizeJournalStream(true); |
romange
approved these changes
May 28, 2025
romange
pushed a commit
that referenced
this pull request
May 28, 2025
fix server: fix partial sync flow Signed-off-by: adi_holden <adi@dragonflydb.io>
This was referenced Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5135
On the error path for incremental snapshot, the stream is finalized from the snapshot fiber by calling SliceSnapshot::FinalizeJournalStream. This ends up with a join call to the snapshot fiber on itself, which triggers an assertion
The error path of incremental snapshotting occurred because when sending the lsn to to the replica flow we sent incorrect lsn number because we first fetch lsn of shard and than migrate the connection. To fix this we now migrate the connection before fetching the lsn.
@abhijat was able to figure out the problem with the flow, I followed up with a PR to fix the lsn and a simple test to reproduce