Skip to content

Conversation

@romange
Copy link
Collaborator

@romange romange commented Jun 10, 2025

ZIPLIST encoding is an legacy format for Redis 6 or older.

We stop saving using ZIPLIST but we still support loading snapshots containing ziplist encodings.

Fixes #4544

@romange romange requested a review from kostasrim June 10, 2025 12:43
ZIPLIST encoding is an legacy format for Redis 6 or older.

We stop saving using ZIPLIST but we still support loading snapshots containing
ziplist encodings.

Fixes #4544

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
kostasrim
kostasrim previously approved these changes Jun 10, 2025
Copy link
Contributor

@kostasrim kostasrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kostasrim
Copy link
Contributor

@romange

/usr/bin/ld: src/server/CMakeFiles/stream_family_test.dir/stream_family_test.cc.o: in function dfly::StreamFamilyTest_SeenActiveTime_Test::TestBody()': /__w/dragonfly/dragonfly/src/server/stream_family_test.cc:1278:(.text+0x822ab): undefined reference to FLAGS_stream_rdb_encode_v2'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
@romange romange merged commit 6a6a010 into main Jun 10, 2025
10 checks passed
@romange romange deleted the Pr4 branch June 10, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deprecate ZIPLIST encoding in rdb_save

3 participants