chore: add -skip-time-min flag to skip initial N minutes during replay traffic #5288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Jun 12, 2025
tools/replay/main.go
Outdated
| var fClientBuffer = flag.Int("buffer", 100, "How many records to buffer per client") | ||
| var fPace = flag.Bool("pace", true, "whether to pace the traffic according to the original timings.false - to pace as fast as possible") | ||
| var fSkip = flag.Uint("skip", 0, "skip N records") | ||
| var fSkipTimeMin = flag.Int("skip-time-min", 0, "skip records in the first N minutes of the recording") |
Collaborator
There was a problem hiding this comment.
i think minutes is too coarse. lets do this in seconds.
Contributor
Author
There was a problem hiding this comment.
In my experience, minutes is the best choice.
I decided to add this option when I had to wait for 120 minutes.
Contributor
Author
There was a problem hiding this comment.
Maybe it's better to add two options, in seconds and in minutes.
Contributor
There was a problem hiding this comment.
You can always convert minutes to seconds, not the other way round. Two flags can be confusing
romange
reviewed
Jun 12, 2025
romange
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces CLI flag -skip-time-min (int) to skip the first N minutes of recorded traffic.