chore: integrate Valkey fixes into stringmatchlen_impl #5323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add more edge-case tests taken from Valkey. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
kostasrim
approved these changes
Jun 18, 2025
Contributor
kostasrim
left a comment
kostasrim
left a comment
There was a problem hiding this comment.
lgtm -- let's see if everything passes
|
|
||
| // TODO: to fix this: TEST_STRINGMATCH("[\\a]", "A", 0, 1); | ||
| TEST_STRINGMATCH("[\\A]", "A", 1, 1); | ||
| // TODO: to fix this: TEST_STRINGMATCH("[\\A]", "a", 0, 1); |
Contributor
There was a problem hiding this comment.
So this is broken for us and valkey ?
| while (stringLen) { | ||
| if (stringmatchlen_impl(pattern + 1, patternLen - 1, string, stringLen, nocase, | ||
| skipLongerMatches)) | ||
| skipLongerMatches, nesting + 1)) |
Contributor
There was a problem hiding this comment.
oh I see the algorithm is recursive and it can blow out the stack (especially for us because fiber stack is small). +1 on this
I wonder if recursion was a problem for Valkey why didn't they rewrite the algorithm to use iterations instead of recursions 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add more edge-case tests taken from Valkey.