test_flask.py works with python3, also added cleaner fstrings#2
Open
LEvinson2504 wants to merge 1 commit intodrandreaskrueger:masterfrom
Open
test_flask.py works with python3, also added cleaner fstrings#2LEvinson2504 wants to merge 1 commit intodrandreaskrueger:masterfrom
LEvinson2504 wants to merge 1 commit intodrandreaskrueger:masterfrom
Conversation
Owner
|
Thanks a lot, that's much appreciated. Do you want to adapt the whole repo like this? Yes, I got your code running with py3: well done. |
Owner
|
but now the same code fails on py27 I'd prefer re-writing it in a way that would work in py27 AND in python3x. I understand your aesthetics argument - but could you live without that here? :-) |
Owner
Or rather: Yes, improve the aesthetics please (since I wrote it back then, my experience has increased too, so I get your point), but in a way that keeps it working in both py27 and py3x. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a few changes so it works with python3, also used fstrings because the look cleaner.