Skip to content

Conversation

@seanlinsley
Copy link
Member

This temporarily reverts #933 since that was a breaking change that shouldn't be included in a patch release, addressing #951

We can add it back after this version is released, and bump the version to 5.0.0

@Alexander-Senko
Copy link
Collaborator

We can add it back after this version is released, and bump the version to 5.0.0

There are other changes still waiting for that.

@seanlinsley
Copy link
Member Author

seanlinsley commented Nov 15, 2025

This CI job seems to stall indefinitely: https://github.com/drapergem/draper/actions/runs/19391461282/job/55486115122?pr=953

It does have this deprecation warning:

DEPRECATION WARNING: ActiveSupport::Configurable is deprecated without replacement, and will be removed in Rails 8.2.
You can emulate the previous behavior with class_attribute.

Which seems to be coming from the unmaintained active_model_serializers gem:

grep -r "ActiveSupport::Configurable" $(bundle show --paths) .
actionpack-8.0.1/lib/abstract_controller/base.rb:    include ActiveSupport::Configurable
active_model_serializers-0.10.15/lib/active_model/serializer.rb:    include ActiveSupport::Configurable

But we're not setting active_support.deprecation = :raise so that shouldn't be treated as a test failure yet. So what's happening?

y-yagi
y-yagi previously approved these changes Nov 15, 2025
Copy link
Collaborator

@y-yagi y-yagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix!

We can add it back after this version is released, and bump the version to 5.0.0

I think we should cut a maintenance branch first like 4-0-stable.

So what's happening?

I'm not sure yet, but I assume there is a deadlock. I will check further later.

@seanlinsley seanlinsley dismissed stale reviews from y-yagi and Alexander-Senko via 4c3a88f November 16, 2025 15:05
@seanlinsley seanlinsley merged commit e8421b7 into master Nov 16, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants