Skip to content

#202 - User Creation: Added error handling #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thekevinm merged 1 commit into from
Apr 30, 2024
Merged

#202 - User Creation: Added error handling #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/app/shared/components/df-profile-details/df-profile-details.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@
">
{{ 'userManagement.controls.username.errors.required' | transloco }}
</mat-error>
<mat-error
*ngIf="
rootForm.get('profileDetailsGroup.username')?.errors?.['minlength']
">
{{ 'userManagement.controls.username.errors.minLength' | transloco }}
</mat-error>
</mat-form-field>
<mat-form-field appearance="fill">
<mat-label>
Expand Down
2 changes: 1 addition & 1 deletion src/app/shared/components/df-user-details/df-user-details-base.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export abstract class DfUserDetailsBaseComponent<T> implements OnInit {
) {
this.userForm = this.fb.group({
profileDetailsGroup: this.fb.group({
username: [''],
username: ['', Validators.minLength(6)],
email: ['', Validators.email],
firstName: [''],
lastName: [''],
Expand Down
3 changes: 2 additions & 1 deletion src/assets/i18n/userManagement/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
"altLabel": "Enter Username",
"optional": "(Optional, defaults to email address)",
"errors": {
"required": "Username is required"
"required": "Username is required",
"minLength": "Username must be at least 6 characters long"
}
},
"email": {
Expand Down