Skip to content

#337 - Fix create scripted api issue #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thekevinm merged 1 commit into from
Dec 5, 2024
Merged

#337 - Fix create scripted api issue #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions src/app/adf-services/df-service-details/df-service-details.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,6 @@ <h3>
placeholder="SQL, AWS, MongoDB, etc."
[ngModelOptions]="{ standalone: true }" />
</mat-form-field>
<!-- <mat-form-field class="dynamic-width" appearance="outline">
<mat-label>{{
'services.controls.serviceType.label' | transloco
}}</mat-label>
<mat-select formControlName="type">
<mat-option *ngFor="let type of serviceTypes" [value]="type.name">
{{ type.label }}
</mat-option>
</mat-select>
</mat-form-field> -->
<div class="full-width">
<div class="grid-wrapper grid-col-auto">
<label
Expand Down Expand Up @@ -415,14 +405,6 @@ <h4 class="text-center" style="color: black !important">
<mat-label class="full-width">Service Definition</mat-label>

<ng-container *ngIf="serviceForm.getRawValue().type === 'rws'">
<!-- <mat-form-field class="full-width" appearance="outline">
<mat-label>Service Definition</mat-label>
<textarea
matInput
rows="10"
[(ngModel)]="serviceDefinition"
[ngModelOptions]="{ standalone: true }"></textarea>
</mat-form-field> -->
<df-file-github
[type]="getControl('type')"
[content]="getConfigControl('content')"
Expand Down Expand Up @@ -455,16 +437,6 @@ <h4 class="text-center" style="color: black !important">
[formControl]="getConfigControl('excelContent')"
[mode]="serviceForm.getRawValue().type"></df-ace-editor>
</ng-container>
<!-- <ng-container *ngIf="this.isNetworkService">
<df-script-editor
[type]="getControl('type')"
formControlName="content"
[storageServiceId]="getServiceDefinitionControl()"
[storagePath]="getConfigControl('storagePath')"
[content]="getConfigControl('content')"
[cache]="serviceData ? serviceData.name : ''"
class="full-width"></df-script-editor
></ng-container> -->
<ng-container *ngFor="let item of viewSchema">
<ng-container
*ngIf="
Expand Down
7 changes: 4 additions & 3 deletions src/app/adf-services/df-service-details/df-service-details.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,11 +433,12 @@ export class DfServiceDetailsComponent implements OnInit {
data.service_doc_by_service_id = null;
} else {
data.config.content = data.config.serviceDefinition;
data.service_doc_by_service_id.format = Number(
this.serviceDefinitionType
);
if (data.service_doc_by_service_id.content === '') {
data.service_doc_by_service_id = null;
} else {
data.service_doc_by_service_id.format = this.serviceDefinitionType
? Number(this.serviceDefinitionType)
: 0;
}
delete data.config.serviceDefinition;
}
Expand Down