Skip to content

[DP-671] Fix issue for dash(-) in namespace #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandrkits merged 2 commits into from
Apr 30, 2025
Merged

[DP-671] Fix issue for dash(-) in namespace #407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
908d29b
fix: preserve dashes in service names and ensure consistent formattin…
oleksandrkits Apr 28, 2025
4c507da
Remove redundunt comments
oleksandrkits Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions src/app/adf-services/df-service-details/df-service-details.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,10 +666,10 @@ export class DfServiceDetailsComponent implements OnInit {
}

validateServiceName(name: string): boolean {
const regex = /^[a-zA-Z0-9_]+$/; // Example regex for valid characters
const regex = /^[a-zA-Z0-9_-]+$/;
if (!regex.test(name)) {
this.warnings.push(
'Service name can only contain letters, numbers, and underscores.'
'Service name can only contain letters, numbers, underscores, and hyphens.'
);
return false;
}
Expand All @@ -680,7 +680,7 @@ export class DfServiceDetailsComponent implements OnInit {
return name
.toLowerCase()
.replace(/\s+/g, '')
.replace(/[^a-z0-9_]/g, '');
.replace(/[^a-z0-9_-]/g, '');
}

gotoSchema() {
Expand All @@ -691,7 +691,8 @@ export class DfServiceDetailsComponent implements OnInit {
gotoAPIDocs() {
const data = this.serviceForm.getRawValue();
this.currentServiceService.setCurrentServiceId(this.serviceData.id);
this.router.navigate([`/api-connections/api-docs/${data.name}`]);
const formattedName = this.formatServiceName(data.name);
this.router.navigate([`/api-connections/api-docs/${formattedName}`]);
}

goBack() {
Expand Down Expand Up @@ -1041,15 +1042,25 @@ export class DfServiceDetailsComponent implements OnInit {
next: result => {
// Attempt to copy API key to clipboard
if (navigator.clipboard) {
navigator.clipboard.writeText(result.apiKey)
navigator.clipboard
.writeText(result.apiKey)
.then(() => {
this.snackbarService.openSnackBar('API Created and API Key copied to clipboard', 'success');
this.snackbarService.openSnackBar(
'API Created and API Key copied to clipboard',
'success'
);
})
.catch(() => {
this.snackbarService.openSnackBar('API Created, but failed to copy API Key', 'success');
this.snackbarService.openSnackBar(
'API Created, but failed to copy API Key',
'success'
);
});
} else {
this.snackbarService.openSnackBar('API Created, but failed to copy API Key', 'success');
this.snackbarService.openSnackBar(
'API Created, but failed to copy API Key',
'success'
);
}

// Navigate to API docs
Expand Down