Skip to content

Excel serviceid fix #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VladyslavTy merged 6 commits into from
Sep 22, 2025
Merged

Excel serviceid fix #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dcd14d4
Merge pull request #444 from dreamfactorysoftware/develop
thekevinm Aug 18, 2025
5d1b35f
Merge pull request #446 from dreamfactorysoftware/develop
VladyslavTy Aug 19, 2025
8c0c17e
added picklist to select file service
codyllord Aug 28, 2025
cdc1db7
rebuilt dist
codyllord Aug 28, 2025
1916538
rebuilt dist
codyllord Aug 28, 2025
529c597
Resolve merge conflicts with develop branch
codyllord Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dist/1326.9234d3c9df390cdf.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion dist/168.4ffc9034d96ad235.js
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions dist/168.79366907eff269ab.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion dist/runtime.1adb24c16ff25b9a.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions src/app/adf-services/df-service-details/df-service-details.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ <h4 class="text-center" style="color: black !important">
<mat-step>
<ng-template matStepLabel>Service Options</ng-template>
<br />

<ng-container *ngIf="viewSchema && !subscriptionRequired">
<ng-container formGroupName="config">
<ng-container *ngIf="!isDatabase || !hasStandardFields">
Expand Down Expand Up @@ -487,6 +488,7 @@ <h4 class="text-center" style="color: black !important">
[icon]="faCircleInfo"
[matTooltip]="'services.controls.serviceType.tooltip' | transloco" />
</mat-form-field>

<mat-form-field
subscriptSizing="dynamic"
class="dynamic-width"
Expand All @@ -502,6 +504,20 @@ <h4 class="text-center" style="color: black !important">
[icon]="faCircleInfo"
[matTooltip]="'services.controls.namespace.tooltip' | transloco" />
</mat-form-field>

<!-- Excel Service Configuration -->
<ng-container *ngIf="serviceForm.getRawValue().type === 'excel'">
<mat-form-field appearance="outline" class="full-width">
<mat-label>Storage Service *</mat-label>
<mat-select formControlName="storageServiceId" required>
<mat-option
*ngFor="let service of availableFileServices"
[value]="service.id">
{{ service.label || service.name }}
</mat-option>
</mat-select>
</mat-form-field>
</ng-container>
<mat-form-field
subscriptSizing="dynamic"
appearance="outline"
Expand Down
Loading