GH-41433: [C++][Gandiva] Fix ascii_utf8 function to return same result on x86 and Arm #41434 #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ GitHub issue apache#41433 could not be retrieved. |
… result on x86 and Arm (apache#41434) Fixing ascii_utf8 function that has different return result on x86 and Arm due to default char type sign difference on those platforms. Added tests to cover existing x86 behavior for ascii symbols with code >127. 1. Added type cast to signed char to save existing x86 behavior on Arm platform. 2. Added tests cases for negative results. UT included. None * GitHub Issue: apache#41433 Authored-by: DenisTarasyuk <denis.tarasyuk@dremio.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
DenisTarasyuk
force-pushed
the
DX-90311
branch
from
d6f6fe6 to
5ec7493
Compare
lriggs
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t on x86 and Arm (apache#41434)
Rationale for this change
Fixing ascii_utf8 function that has different return result on x86 and Arm due to default char type sign difference on those platforms. Added tests to cover existing x86 behavior for ascii symbols with code >127.
What changes are included in this PR?
Are these changes tested?
UT included.
Are there any user-facing changes?
None
Authored-by: DenisTarasyuk denis.tarasyuk@dremio.com