Fix for latest Gerbil v0.18.1-163-ge55e0806#6
Open
fare wants to merge 1 commit intodrewc:mainfrom
Open
Conversation
Contributor
fare
commented
Aug 16, 2025
fare
commented
- Default value must not use previous argument (anymore?)
- Type error (is the type too restrictive?)
Contributor
Author
|
Please test in your setup before to merge. |
vyzo
reviewed
Aug 16, 2025
Contributor
vyzo
left a comment
vyzo
left a comment
There was a problem hiding this comment.
I think this pr should not exist at all, these issues should be fixed in gerbil itself:
- call-with-output-string should have its signature fixed in the builting decls in the compiler
- optionals referring to previous arguments should work; its a regression, so please fix in gerbil and add a test.
| (catch (e) (http-response-write | ||
| res 500 '(("Content-Type" . "text/plain")) | ||
| (with-output-to-string (cut display-exception e)))))) | ||
| (with-output-to-string "" (cut display-exception e)))))) |
Contributor
There was a problem hiding this comment.
if it is too type restrictive it should be fixed in gerbil
| (catch (e) (http-response-write | ||
| res 500 '(("Content-Type" . "text/plain")) | ||
| (with-output-to-string (cut display-exception e)))))) | ||
| (with-output-to-string "" (cut display-exception e)))))) |
| (catch (e) (http-response-write | ||
| res 500 '(("Content-Type" . "text/plain")) | ||
| (with-output-to-string (cut display-exception e)))))) | ||
| (with-output-to-string "" (cut display-exception e)))))) |
|
|
||
| #+begin_src gerbil | ||
| (defmethod {endpoint-match-predicate endpoint} | ||
| (lambda (self (m (endpoint-match self))) |
Contributor
There was a problem hiding this comment.
uhm, this should work though, needs to be fixed in gerbil.
Contributor
Author
|
Good, please ignore this PR for now, but don't close until the issue is fixed in Gerbil. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.