Features/net60 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing net6.0 port of HtmlRenderer
…ately matching PDFSharp, Implemented lines/rectangles in Skia.
Owner
|
Hee Thanks @mstancombe. I must admit not doing al lot anymore with this lib. Do you expect some work from me? |
Author
|
@driekus77 No expectation, just thought you might want these changes in your repo :) I'm happy to keep plugging away in mine, and if you ever want to pull anything in from it, feel free. Maybe one day we can merge all this back into the original fork! but yeah, not likely 😅 |
…s. These might just be removed permenantly in future.
-Implemented image loading using HttpClient -Added demo resources images to console program -Moved sample test png expected location out of root c: folder. Ideally this should be something less platform specific, but haven't crossed that bridge yet.
…n printed h1 element.
Swap Skia SVG NuGet Package
Rename corner-radius to border-radius & Implement Skia border-radius.
Update font size caluclation
Owner
|
Didn't have time to test it but wanted to save the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @driekus77 , I was working on a branch of Html-Renderer and had the SkiaSharp stuff mostly working. However, I was working off a fork of a fork, and then went back to the ArthurHub repo and noticed your PR.
Great work!
I've integrated some of the fixes for Skia that I'd done in my branch into yours, so the PR should fix a heap of things with that.
Still haven't done all of it, but it's a lot closer now :)