feat(design-system): add special icons from figma [AR-41918]#128
Open
mmurawski-dn wants to merge 5 commits intodrivenets:mainfrom
Open
feat(design-system): add special icons from figma [AR-41918]#128mmurawski-dn wants to merge 5 commits intodrivenets:mainfrom
mmurawski-dn wants to merge 5 commits intodrivenets:mainfrom
Conversation
mmurawski-dn
force-pushed
the
drivenets/michal/AR-41918
branch
from
4942a86 to
e73622e
Compare
…ets/michal/AR-41918
mmurawski-dn
force-pushed
the
drivenets/michal/AR-41918
branch
from
739aebe to
c4d7ce7
Compare
Collaborator
Author
|
SVGs copied one to one from here: https://www.figma.com/design/nha3m67y7S57cHCSuQO2gp/DAP-Design-System-1.2?node-id=27983-34521&m=dev adjusted only props names, props passing, and currentColor |
…ets/michal/AR-41918
…esign-system into drivenets/michal/AR-41918
| <path d="M19.1667 15.1562V14.0104H17.5619C17.4829 13.5991 17.3236 13.2158 17.0956 12.8812L18.2311 11.7457L17.421 10.9356L16.2855 12.0711C15.9509 11.8436 15.5676 11.6838 15.1562 11.6047V10H14.0104V11.6047C13.5991 11.6838 13.2158 11.8431 12.8812 12.0711L11.7457 10.9356L10.9356 11.7457L12.0711 12.8812C11.8436 13.2158 11.6838 13.5991 11.6047 14.0104H10V15.1562H11.6047C11.6838 15.5676 11.8431 15.9509 12.0711 16.2855L10.9356 17.421L11.7457 18.2311L12.8812 17.0956C13.2158 17.323 13.5991 17.4829 14.0104 17.5619V19.1667H15.1562V17.5619C15.5676 17.4829 15.9509 17.3236 16.2855 17.0956L17.421 18.2311L18.2311 17.421L17.0956 16.2855C17.323 15.9509 17.4829 15.5676 17.5619 15.1562H19.1667ZM14.5833 16.474C13.5412 16.474 12.6927 15.626 12.6927 14.5833C12.6927 13.5406 13.5406 12.6927 14.5833 12.6927C15.626 12.6927 16.474 13.5406 16.474 14.5833C16.474 15.626 15.6255 16.474 14.5833 16.474Z" /> | ||
| </g> | ||
| <defs> | ||
| <clipPath id="clip0_27983_34547"> |
Collaborator
There was a problem hiding this comment.
There is a tiny possibility the same id will be used in a different svg file (right now it's not). If that happens one/both images will be messed up.
In your PR there are 11 files with this "problem".
If you want to fix it, you can:
- remove
<g clipPath>and try to inline it's children somehow. - Use
useIdfrom React.
Collaborator
Author
There was a problem hiding this comment.
Propably clipPath needs to stay, right? Maybe some build time id would be better? Just not to create new ID each time we render 🤔 Maybe not that big of a deal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AR-41918
screen-capture.5.webm