Open
Conversation
| EXPECT_EQ("Sure.", BobAnswer("?")); | ||
| } | ||
|
|
||
| TEST(Bobtest, BobAnswer_input_exclamation_mark_return_Whoa_chill_out) |
Owner
There was a problem hiding this comment.
вторым тестом должен был быть, что знак вопроса не один в in строка, например
"How are you?"
Collaborator
Author
There was a problem hiding this comment.
причины по которым сделал так:
Тест не был бы красным.
Такой тест я добавил на том этапе, когда он сфейлился бы
| return "Sure."; | ||
| } | ||
| else if (tellBob == "!") | ||
| else if (tellBob.back() == '!') |
Owner
There was a problem hiding this comment.
это исправление должно было быть раньше, еще до написания тестов с 'Whatever.'
Collaborator
Author
There was a problem hiding this comment.
до появления тестов с Whatever не возможно было провести этот рефакторинг, т.к. "Whoa, chill out!" возвращался в else.
| EXPECT_EQ("Fine. Be that way!", BobAnswer("")); | ||
| } | ||
|
|
||
| TEST(Bobtest, BobAnswer_input_qwerty_return_Whateve) |
Owner
There was a problem hiding this comment.
ошибка в названии - Whatever
| } | ||
|
|
||
| if (tellBob.back() == '?') | ||
| switch (tellBob.back()) |
Owner
There was a problem hiding this comment.
рефакторить можно было чуть раньше
driverdevteam
pushed a commit
that referenced
this pull request
May 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Krestol task 1