A simple fix#2500
Open
fe-dagostino wants to merge 7 commits intodrogonframework:masterfrom
Open
Conversation
just updated the signature of the function. const for the return value is ignored and generate a warning/error with gcc.
Removing a warning for missing return value.
fe-dagostino
commented
May 5, 2026
Contributor
Author
fe-dagostino
left a comment
fe-dagostino
left a comment
There was a problem hiding this comment.
Could you please clarify the issue I don't see what is expected.
Member
|
@fe-dagostino Thanks so much for your patch, but there are some extra blank lines that violate clang-format's specifications. Do you need me to help you solve it? |
removing extra spaces
Removing extra spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
missing return value was generating a lot of warning, also modified the constexpr condition since as far as I can see only one of that can be true, so if you have use unit tests for that please confirm the behavior before to merge.