(FEAT)[#397] 라우팅 추가, 세션/컨트리뷰트 이동 일부 적용 #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results29 tests 29 ✅ 20s ⏱️ Results for commit 0c48d85. ♻️ This comment has been updated with latest results. |
workspace
reviewed
May 15, 2025
core/router/router-api/src/main/java/com/droidknights/app/core/router/api/Navigator.kt
Outdated
Show resolved
Hide resolved
build-logic/convention/src/main/kotlin/com/droidknights/app/ComposeAndroid.kt
Outdated
Show resolved
Hide resolved
core/router/router/src/main/java/com/droidknights/app/core/router/LaunchedRouter.kt
Outdated
Show resolved
Hide resolved
workspace
reviewed
May 17, 2025
.../router/src/main/java/com/droidknights/app/core/router/internal/viewmodel/RouteSideEffect.kt
Outdated
Show resolved
Hide resolved
...e/contributor/src/main/java/com/droidknights/app/feature/contributor/ContributorViewModel.kt
Outdated
Show resolved
Hide resolved
...r/router/src/main/java/com/droidknights/app/core/router/internal/viewmodel/RouteViewModel.kt
Outdated
Show resolved
Hide resolved
...er/router/src/main/java/com/droidknights/app/core/router/internal/navigator/NavigatorImpl.kt
Outdated
Show resolved
Hide resolved
core/router/router/src/main/java/com/droidknights/app/core/router/LaunchedRouter.kt
Outdated
Show resolved
Hide resolved
workspace
reviewed
May 21, 2025
|
|
||
| import com.droidknights.app.core.router.api.model.Route | ||
|
|
||
| interface Navigation { |
Contributor
There was a problem hiding this comment.
마지막! 요거는 원래 이름인 Navigator가 좀 더 나은 것 같은데 어떻게 생각하세용?
workspace
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
기존 방식
변경 방식