-
Notifications
You must be signed in to change notification settings - Fork 101
(FEAT)[#422] Router - 추가 적용 #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
2619cf2
(FEAT)[droidknights#422] RouteSessionDetail api 생성 및 기존 RouteModel 제거
s9hn 3bfb09a
(FEAT)[droidknights#422] SessionScreen 이동 적용
s9hn 13450c0
(FEAT)[droidknights#422] SessionDetailScreen 이동 적용
s9hn b50b367
(REFACTOR)[droidknights#422] SessionDetailViewModelTest, SessionListV…
s9hn eb61a5c
(TEST)[droidknights#422] SessionListViewModelTest 이동 테스트 추가
s9hn c582315
(TEST)[droidknights#422] SessionDetailViewModelTest 이동 테스트 추가
s9hn 92b6515
(REFACTOR)[droidknights#422] MainActivity에서 navigateSessionDetail 이동 …
s9hn d123c17
(REFACTOR)[droidknights#422] Router 모듈의 Navigate 함수에 Navigate 파라미터 추가…
s9hn e98b684
(REFACTOR)[droidknights#422] 기존 Route 인터페이스 제거 및 Router-api의 Route 적용
s9hn 08ded06
(FEAT)[droidknights#422] MainTab 이동 구현
s9hn fb95ac2
(REFACTOR)[droidknights#422] 사용하지 않는 Navigate 함수 제거
s9hn b0723f1
(REFACTOR)[droidknights#422] 테스트 함수 이름 한글화
s9hn 40a0260
(REFACTOR)[droidknights#422] 메인탭 이동에 대한 네비게이션 옵션을 MainNavigator가 지정할 …
s9hn 39b1776
(TEST)[droidknights#422] MainViewModelTest 탭 이동 테스트 구현
s9hn a640a3b
(REFACTOR)[droidknights#422] InternalLaunchedRouter 스택이 쌓이지 않는 문제 해결
s9hn eb67da0
(REFACTOR)[droidknights#422] RouteModel -> MainTabRoute 네이밍 수정
s9hn 22dd11e
(REFACTOR)[droidknights#422] CI 에러 해결
s9hn f1a42d7
(REFACTOR)[droidknights#422] Router 모듈 단위 테스트 Navigate 파라미터 수정
s9hn bcb2ddb
(BUILD)[droidknights#422] resolve conflict merge
s9hn e68c283
(BUILD)[droidknights#422] Resolve merge conflict
s9hn e06ec15
(BUILD)[droidknights#422] Resolve merge conflict
s9hn 96ee20a
(REFACTOR)[droidknights#422] SessionDetailViewModelTest, SessionListV…
s9hn e7fc219
(TEST)[droidknights#422] SessionListViewModelTest 이동 테스트 추가
s9hn da9e2d1
(TEST)[droidknights#422] SessionDetailViewModelTest 이동 테스트 추가
s9hn 0522371
(REFACTOR)[droidknights#422] MainActivity에서 navigateSessionDetail 이동 …
s9hn dd27ac3
(REFACTOR)[droidknights#422] 기존 Route 인터페이스 제거 및 Router-api의 Route 적용
s9hn 6537d19
(REFACTOR)[droidknights#422] 테스트 함수 이름 한글화
s9hn c7eddf6
(TEST)[droidknights#422] MainViewModelTest 탭 이동 테스트 구현
s9hn e5653eb
(REFACTOR)[droidknights#422] InternalLaunchedRouter 스택이 쌓이지 않는 문제 해결
s9hn 471024a
(REFACTOR)[droidknights#422] RouteModel -> MainTabRoute 네이밍 수정
s9hn 35dc54e
(REFACTOR)[droidknights#422] CI 에러 해결
s9hn ca458d9
(REFACTOR)[droidknights#422] MainViewModel, MainNavigator의 navigate 책…
s9hn bdc068f
(REFACTOR)[droidknights#422] Bookmark 이동 구현
s9hn 7e0aae8
(REFACTOR)[droidknights#422] Setting 이동 구현
s9hn 84c440d
(REFACTOR)[droidknights#422] Home 이동 구현
s9hn e2fff12
(BUILD)[droidknights#422] Resolve merge conflict
s9hn c59f0a5
(REFACTOR)[droidknights#422] 개행 추가
s9hn 13315e5
(REFACTOR)[droidknights#422] MainTabRoute saveState, launchSingleTop …
s9hn 644dda6
Merge branch '2025/app' into feature/#422-router
taehwandev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
core/navigation/src/main/java/com/droidknights/app/core/navigation/MainTabRoute.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package com.droidknights.app.core.navigation | ||
|
|
||
| import com.droidknights.app.core.router.api.model.Route | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| sealed interface MainTabRoute : Route { | ||
| val saveState: Boolean | ||
| val launchSingleTop: Boolean | ||
|
|
||
| @Serializable | ||
| data object Home : MainTabRoute { | ||
| override val saveState: Boolean = true | ||
| override val launchSingleTop: Boolean = true | ||
| } | ||
|
|
||
| @Serializable | ||
| data object Setting : MainTabRoute { | ||
| override val saveState: Boolean = true | ||
| override val launchSingleTop: Boolean = true | ||
| } | ||
|
|
||
| @Serializable | ||
| data object Bookmark : MainTabRoute { | ||
| override val saveState: Boolean = true | ||
| override val launchSingleTop: Boolean = true | ||
| } | ||
| } |
21 changes: 0 additions & 21 deletions
21
core/navigation/src/main/java/com/droidknights/app/core/navigation/RouteModel.kt
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 6 additions & 8 deletions
14
...mark/src/main/java/com/droidknights/app/feature/bookmark/navigation/BookmarkNavigation.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍