Potential issue with working directory in the rules_loop.sh
#766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't need to be the final outcome, but when I was going through the guide, I couldn't figure out for the life of me why areas wasn't working. Turns out that the way this script is set up means that I had to execute the script from a working directory of
/in order for the pwd in the deleted changes to work.I think we can also pretty it up a bit (I'm not sure why we exactly need to sanitize the $EXEC_DIR as a relative of our invoking directory, I think there is a bug here if we executed without absolute.
I think we can simplify the two down to just forgetting about relative execution, since the guides from osm wiki tells us to execute via the absolute path (
nohup $EXEC_DIR/bin/rules_loop.sh $DB_DIR &, where the two env vars are stored as abolutes)