Skip to content

Handle slashes in Presto schemas for SQLAlchemy URL #280

@yciabaud

Description

@yciabaud

When connecting a PrestoDB database to query a Apache Pulsar SQL worker, errors are occurring when working with a schema containing slashes.

The check from: https://github.com/dropbox/PyHive/blob/master/pyhive/sqlalchemy_presto.py#L106 is raising an exception whereas I expected the schema to contain the slash.

I believe the check should be removed or we need a way to escape the slashes:

  • presto://localhost:8081/pulsar/public/default
  • presto://localhost:8081/pulsar/public%2Fdefault

Example of integration can be found here: apache/superset#7297

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions