Skip to content

Changes the name of generated rules to be valid in more cases #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattnathan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changes the name of generated rules to be valid in more cases #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion node/tools/npm/gen_build_npm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,18 @@ def encode_npm_name(name):
'''
return 'npm-gen-' + name.replace('/', '-').replace('@', 'at_')

def encode_rule_name(pkg, name):
'''
Encode `name` so that it's a valid bazel rule name. If pkg ends
with the same path segments as the name then they will be removed
so that pkg:my/module, name:@my/module will return just 'module'
'''
name = name.replace('@', '')
if pkg.replace('\\', '/').endswith(name):
name = name.split('/')[-1]
return name.replace('/', '_')


def get_npm_library_contents(target_dir, npm_req):
''' Return a list of the contents of the npm module and its dependencies. '''
name = get_dep_name(npm_req)
Expand Down Expand Up @@ -204,7 +216,7 @@ def generate_build_file_and_shrinkwrap(npm_req, output):

contents = get_npm_library_contents(output, npm_req)

name = get_dep_name(npm_req)
name = encode_rule_name(output, get_dep_name(npm_req))

npm_rule = BazelRule(
attr_map = {
Expand Down