-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: the path argument is now variadic
#8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@wolfgangwalther Feel free to review it :) |
|
Diff looks good, but something doesn't quite work, yet, I think. I put this PR's rev into the treefmt-mdcr-nixpkgs PR and removed the script. Still something is odd in the log output: The order of log outputs, the second line ("Error processing ...:") should come first, I think? Otherwise the |
9bd2a1a to
f91b392
Compare
|
Fixed, try again please. |
Or maybe not. I think the previous version didn't report syntax errors properly (aka, at all)? Looks like the error logging was only really added here? |
It should not, the logging hasn't changed, please try again and let me know. |
f91b392 to
bf68f83
Compare
|
Ah my basc script needed |
bf68f83 to
ae9c179
Compare
wolfgangwalther
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! Thank you ❤️!
This PR
pathargument is variadicFix #6