Skip to content

chore(controller): pod failed do not rollback #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duanhongyi merged 1 commit into from
Aug 30, 2024
Merged

chore(controller): pod failed do not rollback #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rootfs/scheduler/resources/pod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,7 @@ def _handle_pod_errors(self, pod, reason, message):
'ImagePullBackOff',
'RegistryUnavailable',
'ErrImageInspect',
"CreateContainerError",
]
# Image event reason mapping
event_errors = {
Expand All @@ -537,7 +538,7 @@ def _handle_pod_errors(self, pod, reason, message):

# Nicer error than from the event
# Often this gets to ImageBullBackOff before we can introspect tho
if reason == 'ErrImagePull':
if reason in ['ErrImagePull', 'CreateContainerError']:
raise KubeException(message)

# collect all error messages of worth
Expand Down