You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function Get-LocalizedDataForInvariantCulture.ps1 contains hardcoded debug messages that violate the project's localization guidelines. Per the coding guidelines, all Write-Debug, Write-Verbose, Write-Error, and Write-Warning messages must be localized using $script:localizedData.
Current Issues
The following debug messages are hardcoded:
Line 106: 'Found an extension to the file name to search. Stripping...'
Add localized string keys to the appropriate strings PSD1 file:
ConvertFrom-StringData@' GetLocalizedDataForInvariantCulture_GettingFile = Getting file {0}. (GLDFIC0001) GetLocalizedDataForInvariantCulture_FoundExtension = Found an extension to the file name to search. Stripping... (GLDFIC0002) GetLocalizedDataForInvariantCulture_FoundFile = Found '{0}'. (GLDFIC0003) GetLocalizedDataForInvariantCulture_FileNotFound = File '{0}' not found. (GLDFIC0004)'@
Replace hardcoded strings with localized versions:
Problem
The function
Get-LocalizedDataForInvariantCulture.ps1contains hardcoded debug messages that violate the project's localization guidelines. Per the coding guidelines, all Write-Debug, Write-Verbose, Write-Error, and Write-Warning messages must be localized using$script:localizedData.Current Issues
The following debug messages are hardcoded:
'Found an extension to the file name to search. Stripping...'"Found '$filePath'.""File '$filePath' not found."'Getting file {0}'(modified in PR Change verbose messages to debug messages #163)Solution
Context
This issue was identified during review of PR #163: #163 (comment)
References
Requested by: @dan-hughes