Skip to content

Format-Path add ExpandEnvironmentVariable Parameter#152

Merged
johlju merged 4 commits intodsccommunity:mainfrom
dan-hughes:fix/issue-147
Jun 2, 2025
Merged

Format-Path add ExpandEnvironmentVariable Parameter#152
johlju merged 4 commits intodsccommunity:mainfrom
dan-hughes:fix/issue-147

Conversation

@dan-hughes
Copy link
Copy Markdown
Contributor

@dan-hughes dan-hughes commented May 26, 2025

Pull Request (PR) description

Add ExpandEnvironmentVariable to Format-Path.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@dan-hughes
Copy link
Copy Markdown
Contributor Author

@johlju,

The changelog seems to be out of sync. The last release has no entry.

Back to this PR, should the Environment Variables be expanded first before any other logic?

@johlju
Copy link
Copy Markdown
Member

johlju commented May 30, 2025

The changelog seems to be out of sync. The last release has no entry.

It's because we merged this PR and released it when the change was not in the unreleased section. I missed that. 🙂
https://github.com/dsccommunity/DscResource.Common/pull/151/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed

@johlju
Copy link
Copy Markdown
Member

johlju commented May 30, 2025

...should the Environment Variables be expanded first before any other logic?

I think it might be better it expand them first because that could expand to a drive letter etc. 🤔

@dan-hughes dan-hughes marked this pull request as ready for review May 30, 2025 09:54
Copy link
Copy Markdown
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-hughes)

@johlju johlju merged commit f8242e2 into dsccommunity:main Jun 2, 2025
9 checks passed
@dan-hughes dan-hughes deleted the fix/issue-147 branch June 2, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Format-Path: Support expand environment variables

2 participants