Skip to content

Final Verbose to Debug changes #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johlju merged 4 commits into from
Aug 28, 2025
Merged

Final Verbose to Debug changes #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03de1f3
Move more to Write-Debug
dan-hughes Aug 28, 2025
33fbeac
Update changelog
dan-hughes Aug 28, 2025
3fcf307
Update changelog
dan-hughes Aug 28, 2025
825929c
Fix comment
dan-hughes Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
information about parameter state differences.
- Use ArrayList and not fixed size array.
- Remove some ForEach-Object usage.
- Move non error Verbose messages to Debug. [#157](https://github.com/dsccommunity/DscResource.Common/issues/157).
- `Test-ModuleExist`
- Changed module filtering messages from `Write-Verbose` to `Write-Debug`
for internal implementation details.
Expand Down
6 changes: 3 additions & 3 deletions source/Public/Compare-DscParameterState.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ function Compare-DscParameterState
#endregion end of enumeration
if ($ReverseCheck)
{
Write-Verbose -Message $script:localizedData.StartingReverseCheck
Write-Debug -Message $script:localizedData.StartingReverseCheck
$reverseCheckParameters = @{} + $PSBoundParameters
$reverseCheckParameters['CurrentValues'] = $DesiredValues
$reverseCheckParameters['DesiredValues'] = $CurrentValues
Expand Down Expand Up @@ -629,7 +629,7 @@ function Compare-DscParameterState
[array]$returnValue = $returnValue.Where({ $_.InDesiredState -eq $false })
}

#change verbose message
#change debug message
if ($IncludeInDesiredState.IsPresent)
{
$returnValue.ForEach({
Expand All @@ -642,7 +642,7 @@ function Compare-DscParameterState
$localizedString = $script:localizedData.PropertyNotInDesiredStateMessage
}

Write-Verbose -Message ($localizedString -f $_.Property)
Write-Debug -Message ($localizedString -f $_.Property)
})
}
<#
Expand Down