Rename *-SqlDscBIReportServer to *-SqlDscPowerBIReportServer#2363
Rename *-SqlDscBIReportServer to *-SqlDscPowerBIReportServer#2363
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughRenamed BI Report Server public commands from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Pre-merge checks✅ Passed checks (5 passed)
Comment |
… with aliases Co-authored-by: johlju <7189721+johlju@users.noreply.github.com>
…nd names Co-authored-by: johlju <7189721+johlju@users.noreply.github.com>
Co-authored-by: johlju <7189721+johlju@users.noreply.github.com>
Updated to use |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/Unit/Classes/SqlRSSetup.Tests.ps1 (1)
869-918: Update Install and Repair mocks to match actual PowerBI command names.The mocks for
Install-SqlDscBIReportServer(lines 731, 762) andRepair-SqlDscBIReportServer(lines 1007, 1038) reference outdated command names. These should be updated toInstall-SqlDscPowerBIReportServerandRepair-SqlDscPowerBIReportServerrespectively, consistent with the correctedUninstall-SqlDscPowerBIReportServermocks in the verified lines 869-918. All three commands were renamed to include the PowerBI suffix in the source code.
🧹 Nitpick comments (6)
CHANGELOG.md (1)
24-26: Add explicit issue reference for the rename entryThe description is clear and matches the PR intent, but this bullet is missing a reference to the tracking issue, unlike most other Unreleased entries. To align with the changelog guidelines, consider appending an issue link, e.g.:
- Renamed commands `*-SqlDscBIReportServer` to `*-SqlDscPowerBIReportServer` for - clarity. The old names `*-SqlDscBIReportServer` and `*-SqlDscPBIReportServer` - are available as aliases for backward compatibility. + Renamed commands `*-SqlDscBIReportServer` to `*-SqlDscPowerBIReportServer` for + clarity. The old names `*-SqlDscBIReportServer` and `*-SqlDscPBIReportServer` + are available as aliases for backward compatibility + ([issue #2071](https://github.com/dsccommunity/SqlServerDsc/issues/2071)).tests/Integration/Commands/Uninstall-SqlDscPowerBIReportServer.Integration.Tests.ps1 (1)
54-54: Update variable name for consistency.The splat variable name
$uninstallSqlDscBIReportServerParametersshould be updated to reflect the new command name for consistency.Apply this diff to update the variable name:
- $uninstallSqlDscBIReportServerParameters = @{ + $uninstallSqlDscPowerBIReportServerParameters = @{Also update the variable reference on line 63:
- $null = Uninstall-SqlDscPowerBIReportServer @uninstallSqlDscBIReportServerParameters + $null = Uninstall-SqlDscPowerBIReportServer @uninstallSqlDscPowerBIReportServerParameterstests/Integration/Commands/Install-SqlDscPowerBIReportServer.Integration.Tests.ps1 (1)
46-46: Update variable name for consistency.The splat variable name
$installSqlDscBIReportServerParametersshould be updated to reflect the new command name for consistency.Apply this diff to update the variable name:
- $installSqlDscBIReportServerParameters = @{ + $installSqlDscPowerBIReportServerParameters = @{Also update the variable reference on line 57:
- $null = Install-SqlDscPowerBIReportServer @installSqlDscBIReportServerParameters -ErrorAction 'Stop' + $null = Install-SqlDscPowerBIReportServer @installSqlDscPowerBIReportServerParameters -ErrorAction 'Stop'tests/Integration/Commands/Repair-SqlDscPowerBIReportServer.Integration.Tests.ps1 (1)
53-64: Invocation updated to Repair-SqlDscPowerBIReportServerThe splatting comment and the call now target
Repair-SqlDscPowerBIReportServer, with parameters (AcceptLicensingTerms,MediaPath,LogPath,SuppressRestart,Verbose,ErrorAction = 'Stop',Force = $true) unchanged and compliant with integration test guidelines. You might optionally rename$repairSqlDscBIReportServerParametersin a future cleanup for full “PowerBI” terminology consistency, but it’s not functionally important.tests/Unit/Public/Uninstall-SqlDscPowerBIReportServer.Tests.ps1 (1)
90-121: Mandatory-parameter uninstall scenarios point to new cmdletAll mandatory-parameter scenarios (
-Confirm:$false,-Force,-WhatIf) now callUninstall-SqlDscPowerBIReportServerand still assert the correct flags ($Uninstall,$Force,MediaPath) onInvoke-ReportServerSetupAction. For future cleanups, you could assign unused return values to$null(e.g.$null = Uninstall-SqlDscPowerBIReportServer ...) to align with the unit test guidelines, but it’s not a behavioral issue. Based on learnings, this is a style-only consideration.tests/Unit/Public/Install-SqlDscPowerBIReportServer.Tests.ps1 (1)
92-121: Mandatory-parameter install scenarios target new cmdletThe
-Confirm:$false,-Force, and-WhatIfscenarios now invokeInstall-SqlDscPowerBIReportServerand still assert thatInvoke-ReportServerSetupActionreceives$Install,AcceptLicensingTerms, and the correctMediaPath. As in the uninstall tests, you could optionally assign unused results to$nullfor strict adherence to the unit test guidelines, but behavior is unchanged. Based on learnings, this is a style-only refinement.
|
in tests/Unit/Classes/SqlRSSetup.Tests.ps1 The mocks for Install-SqlDscBIReportServer (lines 731, 762) and Repair-SqlDscBIReportServer (lines 1007, 1038) reference outdated command names. These should be updated to Install-SqlDscPowerBIReportServer and Repair-SqlDscPowerBIReportServer respectively, consistent with the corrected Uninstall-SqlDscPowerBIReportServer mocks in the verified lines 869-918. All three commands were renamed to include the PowerBI suffix in the source code. In CHANGELOG.md (1) The description is clear and matches the PR intent, but this bullet is missing a reference to the tracking issue, unlike most other Unreleased entries. To align with the changelog guidelines, consider appending an issue link, e.g.: - Renamed commands `*-SqlDscBIReportServer` to `*-SqlDscPowerBIReportServer` for
- clarity. The old names `*-SqlDscBIReportServer` and `*-SqlDscPBIReportServer`
- are available as aliases for backward compatibility.
+ Renamed commands `*-SqlDscBIReportServer` to `*-SqlDscPowerBIReportServer` for
+ clarity. The old names `*-SqlDscBIReportServer` and `*-SqlDscPBIReportServer`
+ are available as aliases for backward compatibility
+ ([issue #2071](https://github.com/dsccommunity/SqlServerDsc/issues/2071)). |
… CHANGELOG Co-authored-by: johlju <7189721+johlju@users.noreply.github.com>
Fixed in commit 4d97498:
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2363 +/- ##
====================================
Coverage 94% 94%
====================================
Files 166 166
Lines 9780 9780
====================================
Hits 9221 9221
Misses 559 559
🚀 New features to boost your workflow:
|
johlju
left a comment
johlju
left a comment
There was a problem hiding this comment.
@johlju reviewed 9 of 14 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @copilot)
Pull Request (PR) description
Renamed commands from
*-SqlDscBIReportServerto*-SqlDscPowerBIReportServerfor clarity. Maintains backward compatibility via aliases for both*-SqlDscBIReportServerand*-SqlDscPBIReportServer.Changes:
[Alias()]attribute for backward compatibility (following module's standard pattern)Example usage:
This Pull Request (PR) fixes the following issues
None
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
Original prompt
*-SqlDscBIReportServer: Rename to*-SqlDscPowerBIReportServer#2071💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
This change is