Dev 18 exclude dirs2#23
Dev 18 exclude dirs2#23Arturas-K wants to merge 8 commits intodsccommunity:devfrom Arturas-K:dev-18-ExcludeDirs2
Conversation
…ce, Test-TargetResource and Get-RobocopyArguments functions; * Internal calls to Get-RobocopyArguments now use Splatting @psBoundParameters;
Updated unreleased section;
|
Hi, Code review feedback would be appreciated. |
|
Looks good. I know we don't have tests for this resource, but could you add one for the new functionality? Thanks Review status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion. Examples/xRobocopy.SimpleCopyOptions.ps1, line 49 [r1] (raw file):
Minor: typo. "Exclude". Several instances below Comments from Reviewable |
|
I'm working on unit test coverage for this resource, i'll merge it into this branch when they are finished Review status: 0 of 6 files reviewed at latest revision, all discussions resolved. Examples/xRobocopy.SimpleCopyOptions.ps1, line 49 [r1] (raw file):
|
|
as of last commit closes #24 |
|
Reviewed 3 of 5 files at r1, 3 of 3 files at r2. DSCResource.Tests, line 1 at r2 (raw file):
I don't see any unit tests and integration tests. Did i miss something? Comments from Reviewable |
|
Labeling this as abandoned as the original author has not been active after the last PR comment. A PR with the abandoned label can be continued by other contributor in the community. |
Closes #18;
Added workaround examples for #19;
This change is