Fix: Replace bare print with warning and remove deprecated Python 2 code#556
Open
mithlohar144 wants to merge 4 commits intodswah:mainfrom
Open
Fix: Replace bare print with warning and remove deprecated Python 2 code#556mithlohar144 wants to merge 4 commits intodswah:mainfrom
mithlohar144 wants to merge 4 commits intodswah:mainfrom
Conversation
mithlohar144
commented
Mar 28, 2026
mithlohar144
commented
- Replace bare 'print()' statement with 'warnings.warn()' in pygam.py line 821 for convergence alerts
- Remove deprecated Python 2 compatibility code for StringIO import in test_GAM_methods.py
- Simplify import to use only Python 3 'io.StringIO'
- All tests pass with these changes
- Replace bare 'print()' statement with 'warnings.warn()' in pygam.py line 821 for convergence alerts - Remove deprecated Python 2 compatibility code for StringIO import in test_GAM_methods.py - Simplify import to use only Python 3 'io.StringIO' - All tests pass with these changes
Author
|
I addressed the CI follow-up items and pushed an update. Fixed the pre-commit formatting issue (trailing whitespace) |
Author
|
I addressed the CI follow-up items and pushed an update. Fixed the pre-commit formatting issue (trailing whitespace) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.