Fix Core.get_params to exclude fitted attributes#559
Open
2024itb047samata wants to merge 4 commits intodswah:mainfrom
Open
Fix Core.get_params to exclude fitted attributes#5592024itb047samata wants to merge 4 commits intodswah:mainfrom
2024itb047samata wants to merge 4 commits intodswah:mainfrom
Conversation
Author
2024itb047samata
left a comment
2024itb047samata
left a comment
There was a problem hiding this comment.
Hi, this PR addresses issue #521.
I noticed that workflows are awaiting approval. Please let me know if I should make any changes or updates in the meantime.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #521
Problem
Core.get_params returns fitted attributes and internal state, violating sklearn API.
Fix
_Testing