fix(core): prevent mutation via deepcopy in get_params#562
Open
Aditya-9215 wants to merge 1 commit intodswah:mainfrom
Open
fix(core): prevent mutation via deepcopy in get_params#562Aditya-9215 wants to merge 1 commit intodswah:mainfrom
Aditya-9215 wants to merge 1 commit intodswah:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where
get_params()returns references to mutable nested objects,allowing unintended mutation of internal model state.
Problem
Currently:
params = gam.get_params()
params["terms"][0].lam = 1000
mutates the original model.
This violates sklearn’s estimator API expectations and can break clone(),
GridSearchCV, and reproducibility.
Solution
Core.get_params()to return deep copies of parametersTests
Added test:
test_get_params_does_not_mutate_modelNotes
Deepcopy introduces minor overhead but ensures correctness and API compliance.
🔗 Related Issue
Closes #522