Closed
Conversation
a11c8cb to
4c01863
Compare
4c01863 to
49fe623
Compare
Author
|
I just rebased. @dtolnay do you have any comments on this? |
|
This PR has been open for quite a while, are you going to review it @dtolnay anytime soon? |
|
@dtolnay what would be prerequisute for merge please ? thank you a lot |
dtolnay
reviewed
Jul 14, 2023
Owner
dtolnay
left a comment
There was a problem hiding this comment.
I would prefer to consider this only after it works on stable rustc.
Thanks anyway for the PR!
|
okey, will continue use fork. btw this pr does not required nightly on std? so other users intact, only who want no std will be nightly? |
Contributor
|
I found this after going down the same road. Here's a version that has all tests passing on both |
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned by #196, nightly now has the
error_in_corefeature. This make no_std support pretty straightforward (just replacestdwithcorein a few places).Some tests don't work on on no_std to keep the commit small for now. Maybe this is fine until
error_in_coreis merged, because there are only 5 lines in#[cfg(not(feature = "std"))]guards, so running the tests withstddisabled hardly increases coverage anywayOnce
error_in_coreis in stable, even this little trick:can be removed, or not, depending on how important the MSRV guarantees are.
Thoughts?