Closed
Conversation
This was inspired by reading a blog post that showed some shortcomings of thiserror compared to snafu in capturing backtraces. The approach here captures a SpanTrace created by the tracing-error crate. https://docs.rs/tracing-error/ Note: this is a fairly mechanical copy of the relevant backtrace methods for discussion. I have not yet checked whether theres simplifications that make sense. It also is problematic due to the unstable version of the tracing crates, so it's doubtful that this should be merged as-is. My goal with this PR is to start a conversation about how it might work. Fixes dtolnay#400
joshka
force-pushed
the
jm/spantraces
branch
from
816b298 to
2982972
Compare
dtolnay
reviewed
Dec 21, 2024
Owner
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
Thanks for the PR, and for linking the blog post and discussion forum in your issue.
I'm happy with people using snafu for this functionality (and more).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was inspired by reading a blog post that showed some shortcomings
of thiserror compared to snafu in capturing backtraces.
The approach here captures a SpanTrace created by the tracing-error
crate. https://docs.rs/tracing-error/
Note: this is a fairly mechanical copy of the relevant backtrace methods
for discussion. I have not yet checked whether theres simplifications
that make sense. It also is problematic due to the unstable version of
the tracing crates, so it's doubtful that this should be merged as-is.
My goal with this PR is to start a conversation about how it might work.
Fixes #400