Replace paths using case-insensitive comparison#75
Closed
davidhewitt wants to merge 1 commit intodtolnay:masterfrom
davidhewitt:master
Closed
Replace paths using case-insensitive comparison#75davidhewitt wants to merge 1 commit intodtolnay:masterfrom davidhewitt:master
davidhewitt wants to merge 1 commit intodtolnay:masterfrom
davidhewitt:master
Conversation
|
@davidhewitt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #73
Instead of trying to craft an OS-specific solution there, I figured why not just use case-insensitive search when doing all the path-based replacement.
Technically this is only correct for case-insensitive filesystems, but I would be surprised if there is a situation where this is going to cause issues for anyone.