Wrong replacement for UnitE in configure.ac

[Gnappuraz]

define(_COPYRIGHT_HOLDERS_SUBSTITUTION,[[UnitE Core]])
this should be Unit-e Core I believe since it goes in the copyrights.

AC_INIT([UnitE Core],[_CLIENT_VERSION_MAJOR._CLIENT_VERSION_MINOR._CLIENT_VERSION_REVISION],[https://github.com/unite/unite/issues],[unite],[https://bitcoincore.org/])
Here also we want to replace for sure at least the https://bitcoincore.org/ as soon as we have a website. About the package define in AC_INIT probably we can't change it because is used to build the exec, but I'm not sure.

[cornelius]

Looking at old issues...

define(_COPYRIGHT_HOLDERS_SUBSTITUTION,[[UnitE Core]])
this should be Unit-e Core I believe since it goes in the copyrights.

This is the question of what is the name of the project, and what is the name of the software. Do we have a decision about that?

UnitE Core, as it's done by clonemachine, feels a bit weird, as it more seems like an artifact of the history of Bitcoin and the automatic substitution, or is this what we have chosen as name for the software?

I haven't seen Unit-e before.

AC_INIT([UnitE Core],[_CLIENT_VERSION_MAJOR._CLIENT_VERSION_MINOR._CLIENT_VERSION_REVISION],[https://github.com/unite/unite/issues],[unite],[https://bitcoincore.org/])
Here also we want to replace for sure at least the https://bitcoincore.org/ as soon as we have a website. About the package define in AC_INIT probably we can't change it because is used to build the exec, but I'm not sure.

Agreed with replacing https://bitcoincore.org by, I suppose, http://unit-e.io.

I don't think the package name is used to build the exec. It's more a project name which is used as descriptive name or to derive something like tarball names, if not given explicitly like in our case, IIRC.

[cornelius]

This is the pull request to change it in the code: dtr-org/unit-e#650. clonemachine still needs to be changed to do the right substitutions here.

[cornelius]

This needs to be done in clonemachine:

• Make sure the AC_INIT call in configure.ac is substituted correctly.
• Make sure that the upstream attribution in LicenseInfo() from src/init.cpp mentions Bitcoin Core. This indirectly is related to the AC_INIT changes because the behavior of this part of the code depends on the values set by AC_INIT.