Apply new workaround for InstaJustify issue #46
Conversation
Signed-off-by: Andres Correa Casablanca <andres@thirdhash.com>
Does it happen because node runs out of mature coins? In that case, you can try to use small |
Indeed, this is already done (so we have at least slightly above 100 coins per proposer), but I don't want to overshoot. I think it's better to know what's the optimal number so we can minimize the effective difficulty change once the maturity rule starts. |
experiments/forking_simulation.py
Outdated
| self.nodes[validator_id].importmasterkey( | ||
| regtest_mnemonics[self.num_proposer_nodes + idx]['mnemonics'] | ||
| lucky_proposer = self.nodes[lucky_proposer_id] | ||
| for proposer_id in self.proposer_node_ids: |
There was a problem hiding this comment.
It would be nice to add a comment telling that the lucky proposer creates wallets for other proposers and temporarily uses them for staking.
There was a problem hiding this comment.
As I'm already working on this part of the code for a new PR, I'll apply your suggestion there.
Signed-off-by: Andres Correa Casablanca <andres@thirdhash.com>
2 participants
This PR enables again the auto-finalization / insta-justify feature, and mitigates a newly introduced stalling problem by using all the proposer keys in a single node during the initialization phase (although is does not work as smooth as it should, because it gets stuck for a few minutes for each individual sub-experiment before all the nodes can be spawned).
The remaining stalling problems can be mitigated by fine-tuning some parameters (like how many blocks do we wait until the maturity rules are applied, or the initial block difficulty), but I leave this for future PRs.
Signed-off-by: Andres Correa Casablanca andres@thirdhash.com