Skip to content

P2PKH output are stakeable #997

@Gnappuraz

Description

@Gnappuraz

Describe the bug
// UNIT-E TODO: Restrict to witness programs only once #212 is merged (fixes #48) hasn't been removed hence any P2PKH output is considered stakeable but once we try to sign a just created block we'll fail to ExtractP2WPKHKeys() cause the utxo is not a witness compatible one.

To Reproduce
Create a legacy address, send all the funds there, try to propose.

Expected behavior
We should not be able to stake coins that have a non-witness script.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugA problem of existing functionalitytechnical debtCleaning up code which is there for historical reasons

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions